search

NVlabs / FPSci

Aim Training Experiments
Other
70 stars 23 forks source link

Targets without a `destSpace` parameter cause FPSci to crash. #304

Closed ArjunMadhusudan closed 3 years ago

ArjunMadhusudan commented 3 years ago

If no destSpace is provided for a target in the config files, FPSci crashes despite being programmed to use world by default.

bboudaoud-nv commented 3 years ago

The following target (w/o a destSpace specified) works in my configuration:

        {
            id = "point"; 
            destinations = [{ t: 0, xyz: Point3(38.75, -1.3, 0.7)}];
        }

Admittedly this is an extremely simple (point-spawned) target that might be missing the edge case that caused the failure.

@ArjunMadhusudan can you post the full target config that crashes without the destSpace being specified so I can reproduce the error.

jspjutNV commented 3 years ago

As @bboudaoud-nv said, I don't believe it's a problem to have no destSpace, but I do think that it won't run without specifying enough information. Hopefully the startup error tells you what went wrong. If it doesn't, that kind of startup error is something we should root cause and create a better error message for. Given no further discussion on this topic, I'm going to close this one. Please open a new issue if there's a crash without helpful error message.