search

NVlabs / FPSci

Aim Training Experiments
Other
70 stars 23 forks source link

Add `clearMissDecalsWithReference` parameter #322

Closed bboudaoud-nv closed 3 years ago

bboudaoud-nv commented 3 years ago

This branch adds support for a clearMissDecalsWithReference parameter that allows the experiment designer to specify whether or not miss decals created while firing at the reference target are cleared when the trial task begins. The parameter defaults to false to preserve historical behavior. To enable, add:

clearMissDecalsWithReference = true;

to your experiment config.

joohwankimNV commented 3 years ago

Noticing a bug regarding when decals are cleared. I think we want to clear decals together with reference target (at the beginning of pretrial period). Right now the decals are cleared after pretrial period.

jspjutNV commented 3 years ago

Noticing a bug regarding when decals are cleared. I think we want to clear decals together with reference target (at the beginning of pretrial period). Right now the decals are cleared after pretrial period.

The latest commit should have fixed this to match your description. If you have a chance to try it again, make sure it's working how you expect and we can merge this PR.