NVlabs / FPSci

Aim Training Experiments
Other
67 stars 23 forks source link

Experiment and user selection interaction #348

Open bboudaoud-nv opened 2 years ago

bboudaoud-nv commented 2 years ago

When running in developer mode the experiment selection and user selection process appears to interact problematically from the in-app menu.

Essentially the ability to select a different experiment from the experiment drop-down in the user menu without "loading" it in the sense of pressing the "Select Experiment" button in the menu allows for users to accidentally overwrite another experiment's user status with the status from the currently loaded one.

You can reproduce this issue by:

  1. Open FPSci in developer mode (developerMode = true in startup config)
  2. Select a different experiment (w/ different session names) from the experiment drop-down menu but DO NOT click the "Select Experiment" button
  3. Press the "Select User" button to select the current user (or another one)
  4. Now press the "Select Experiment" button to produce an error (session ID from user status missing from experiment)

You will also notice that now the user status file for the experiment that was selected in the drop down, but not "loaded" in the sense of pressing the "Select Experiment" button, has been written with the originally loaded experiment's user status, breaking loading this experiment on all future runs of FPSci.

bboudaoud-nv commented 2 years ago

For now you should attempt to avoid this state by always pressing the "Select Experiment" button prior to taking another action from the user menu.

In the event the user status file is overwritten by this bug, you may be able to revert the changes if the overwritten user status is checked into git. Otherwise you will need to rely on a local/alternative backup to restore your user config.