search

NVlabs / FPSci

Aim Training Experiments
Other
67 stars 23 forks source link

Experiment Configured Reticle #350

Closed bboudaoud-nv closed 2 years ago

bboudaoud-nv commented 2 years ago

This branch adds support for an experiment specified reticle and generally adds some clean-up around previously user-specified only values that can now be configured as part of an experiment configuration (as independent variables).

The behavior is that user-specified reticle behavior is overridden by experiment/session level configuration for these parameters whenever it is provided. This could be extended to include mouse sensitivity parameters as well.

Closes #349

bboudaoud-nv commented 2 years ago

Currently the concept of users changing reticle/sensitivity in the user menu is decoupled from the behavior in app. Perhaps we should automatically set config fields allowing in-app reticle change to false if we detect an experiment-provided config?

Also logging still needs to be updated to for cases in which reticle configuration comes from the experiment. Currently reticle information is only logged to the Users table and is assumed to come from the user config.

jspjutNV commented 2 years ago

If you include sessionParametersToLog = ("reticleIndex", "reticleScale", "reticleColor", "reticleChangeTime"); in the experiment, then the set values will be logged with each session. I think this is a decent work around, and I'm fine with it also being logged in the Users table.

I also don't mind having a settings combination that allows users to think they're changing the reticle, but having those changes prevented by the experiment or session.