search

NVlabs / FPSci

Aim Training Experiments
Other
67 stars 23 forks source link

Remove duplicate save of user status #364

Closed bboudaoud-nv closed 2 years ago

bboudaoud-nv commented 2 years ago

This branch removes a 2nd save of user status from the session state machine.

bboudaoud-nv commented 2 years ago

There were previously 2 calls made to FPSciApp::saveUserStatus() in Session.cpp. This branch removes the call from Session::updatePresentationState() in favor of the call in FPSciApp::markSessionComplete() (also called from Session::updatePresentationState()). This makes sense as it keeps the saveUserStatus() call contained inside of the FPSciApp and avoids the duplicate call we had previously.

jspjutNV commented 2 years ago

I found the other save that we're keeping. It's in m_app->markSessComplete which is called in the trialFeedback state right before it transitions to the sessionFeedback state.