search

NVlabs / FPSci

Aim Training Experiments
Other
67 stars 23 forks source link

`allSessionsCompleteFeedback` doesn't work at startup if all sessions are complete #378

Closed jspjutNV closed 2 years ago

jspjutNV commented 2 years ago

I'm not sure whether I configured it wrong or if there's actually a bug here, but when I added allSessionsCompleteFeedback = "custom message" to my experiment config, the default message still prints on startup when I have all sessions marked as complete for the current user.

bboudaoud-nv commented 2 years ago

This seems like a legitimate bug, but may be challenging to fix depending on desired behavior.

The session state machine is still using a hard coded message ("All sessions complete!") for the case where no session is provided, b/c in the case where all sessions are complete at startup this part of the state machine runs without a valid session configuration. If an experiment-level allSessionsCompleteFeedback message is provided it could be displayed, but we should test this carefully.