search

NVlabs / FPSci

Aim Training Experiments
Other
67 stars 23 forks source link

Add `requireUserAdd` parameter #379

Closed bboudaoud-nv closed 2 years ago

bboudaoud-nv commented 2 years ago

This branch adds support for a requireUserAdd parameter in the general configuration of FPSci. When enabled this flag requires a new user to be added via the existing user menu prior to starting an experiment on each run of FPSci. Note that if FPSci is closed an existing user will still need to create a new user with the current implementation.

The user menu is drawn differently when requireUserAdd = true, will always be shown at startup, and cannot be closed until a new user is added in an effort to make the requirement more self-evident. Once a new user is added the typical user menu behavior resumes (allowing experiment configured user customization).

Merging this PR closes #373

jspjutNV commented 2 years ago

One interesting behavior is that a user is required to be added at startup even if there are existing users who haven't finished, but you can switch to those existing users once you add a new one.

I'm not convinced this is a problem, but we'll want to keep an eye on it in case it causes headaches for designers or users.