NVlabs / FPSci

Aim Training Experiments
Other
70 stars 23 forks source link

Reset weapon cooldowns at the start of kill tests #402

Closed bboudaoud-nv closed 1 year ago

bboudaoud-nv commented 1 year ago

This branch resets the weapon cooldown at the start of target kill tests. Since app state isn't reset between tests the weapon cooldown was (in some cases) preventing a fire event from occurring as the weapon is still in its 0.1s cooldown.

Overall we should probably improve test infrastructure by resetting most of this state in the app prior to running each test instead of just relying on the fixture to do this. It is likely a certain sequence of tests could potentially still result in (illegitimate) failures.

Merging this PR closes #275 and closes #243.