NVlabs / FPSci

Aim Training Experiments
Other
70 stars 23 forks source link

Fixes for reticle preview and `allowReticleChange` #404

Closed bboudaoud-nv closed 1 year ago

bboudaoud-nv commented 1 year ago

This branch fixes a buggy interaction between specifying reticle configuration parameters at the experiment/session/trial level and using allowReticleChange = true to enable the user menu reticle configuration GUI.

The app now treats specifying any reticle configuration at the experiment/session/trial level as equivalent to setting the corresponding field's allowReticle[X]Change parameter to false. Thus the only reticle parameters users are free to configure are those not specified as part of experiment configuration.

Merging this PR closes #361

bboudaoud-nv commented 1 year ago

A fuller list of changes in this branch include: