search

NVlabs / FPSci

Aim Training Experiments
Other
70 stars 23 forks source link

Fix for crash on load w/ experiment complete #408

Closed bboudaoud-nv closed 1 year ago

bboudaoud-nv commented 1 year ago

After trial-level configuration the playerCamera was not initialized in FPSci when loading a completed experiment. This caused null pointer exceptions when running oneFrame(). This branch assigns the playerCamera and adds null checking to avoid these exceptions while still displaying the allSessionsCompleteFeedback message.

jspjutNV commented 1 year ago

I assume this PR is still in draft state just to be sure it's the type of solution to the problem that we really want. If so, I'll start looking at it.

bboudaoud-nv commented 1 year ago

Yeah, exactly. I don't think it will create any negative impacts but certainly worth deciding if this is the behavior we want.