predict_scene_grasps_from_depth_K_and_2d_seg missing some arguments and passing some incorrect arguments

NVlabs / contact_graspnet

Efficient 6-DoF Grasp Generation in Cluttered Scenes

Other

306 stars 107 forks source link

predict_scene_grasps_from_depth_K_and_2d_seg missing some arguments and passing some incorrect arguments #2

Closed abhishek47kashyap closed 3 years ago

abhishek47kashyap commented 3 years ago

predict_scene_grasps_from_depth_K_and_2d_seg() is missing :

rgb: taken by extract_point_clouds()
forward_passes: taken by predict_scene_grasps()

Also, extract_point_clouds() does not take local_regions and filter_grasps.

abhishek47kashyap commented 3 years ago

@MartinSmeyer @arsalan-mousavian Was hoping this PR could get a review, if anything has to be changed or looks good to be merged .. :slightly_smiling_face:

MartinSmeyer commented 3 years ago

Hey @abhishek47kashyap :) Looks good to me! I didn't use that function so the arguments became outdated without notice.