search

NVlabs / flip

A tool for visualizing and communicating the errors in rendered images.
498 stars 41 forks source link

Fix CUDA build (Ubuntu 22.04, CUDA 11.8) #18

Closed mmp closed 7 months ago

mmp commented 1 year ago

This fixes the following warnings/errors, which I saw when building flip with CUDA support on Ubuntu 22.04:

/home/mmp/src/flip/cpp/CUDA/../common/sharedflip.h(20): warning #811-D: const variable "FLIP::FLIPConstants" requires an initializer -- class "struct FLIP::<unnamed>" has no user-provided default constructor

/home/mmp/src/flip/cpp/CUDA/../common/sharedflip.h(28): warning #811-D: const variable "FLIP::GaussianConstants" requires an initializer -- class "struct FLIP::<unnamed>" has no user-provided default constructor

/home/mmp/src/flip/cpp/CUDA/cudaImage.cuh(147): error: identifier "checkStatus" is undefined
          detected during instantiation of "void FLIP::image<T>::FLIP(FLIP::image<FLIP::color3> &, FLIP::image<FLIP::color3> &, float) [with T=float]"
/home/mmp/src/flip/cpp/common/FLIP.cpp(342): here

/home/mmp/src/flip/cpp/CUDA/cudaImage.cuh(169): error: identifier "checkStatus" is undefined
          detected during instantiation of "void FLIP::image<T>::FLIP(FLIP::image<FLIP::color3> &, FLIP::image<FLIP::color3> &, float) [with T=float]"
/home/mmp/src/flip/cpp/common/FLIP.cpp(342): here
inversepixel commented 7 months ago

Sorry for the late reply. Thanks for the fix, which looks good and the tests passes as well.