search

NVlabs / flip

A tool for visualizing and communicating the errors in rendered images.
498 stars 41 forks source link

Allow to build both library and executable with a single build #20

Closed theblackunknown closed 5 months ago

theblackunknown commented 7 months ago

This PR suggests some changes to the CMake setup to allow to build both FLIP library and executable in a single build.

The rationale why I chose to make the executable and not the library optional is because I am in the process of writing a port (i.e. a package) for flip to microsoft/vcpkg (cf. microsoft/vcpkg#36013). In the context of (this) package manager, we usually create library by default, and then can optionally opt-in to create tool too.

inversepixel commented 7 months ago

Hi there!

Sorry for the late reply. We are in the middle of changing so the the entire code for the image metric is located in a single header with no dependencies on any other image headers etc. Hopefully, we are done within a week or so. Would that make your life easier? I.e., no library is needed then.

/Tomas

inversepixel commented 7 months ago

The single header version of FLIP has now been pushed to main.

theblackunknown commented 7 months ago

Hi @inversepixel sorry for the late reply too :) This should definitely be helpful, I'll have a look when the times allow to incorporate those new changes !

inversepixel commented 5 months ago

Closing since we switched to a single header file. Hoping this helps, otherwise post again.

theblackunknown commented 5 months ago

Hi @inversepixel sorry for the long silence, the new approach should help me to do things in a better way I think ! It is fine to close this for now, I'll re-open or open a new one if needed !