search

NVlabs / flip

A tool for visualizing and communicating the errors in rendered images.
497 stars 41 forks source link

fix default argument mutation #33

Closed Latios96 closed 3 months ago

Latios96 commented 3 months ago

This PR fixes issue #32

Instead of mutating the provided inputParameters, I populate a fresh py::dict with the parameters

I don't know if this is the best fix, but it worked for me.

inversepixel commented 3 months ago

Thanks so much for reporting this issue and for the fix! By the way, we added "Latios96" in the Acknowledgement at the bottom of https://github.com/NVlabs/flip Let us know if you want to be mentioned in some other way.

Latios96 commented 3 months ago

@inversepixel Oh thank you so much for adding me to the Acknowledgement! If you could mention my clear name Jan Honsbrok there, that would be great.

inversepixel commented 3 months ago

Thanks! I've changed it to Jan Honsbrok now.