NVlabs / imaginaire

NVIDIA's Deep Imagination Team's PyTorch Library
Other
3.99k stars 444 forks source link

Fix Google Drive download and specify opencv version #151

Open adwiii opened 2 years ago

adwiii commented 2 years ago

In trying to set up the repository to recreate the World Consistent Video2Video, I hit two errors that I have fixed in this PR.

The Google Drive download protocol used in io.py no longer works due to a change in how Google Drive handles requests. The current io.py will cause all downloads to silently fail because it will download a Google Drive HTML warning. The original logic appears to be similar to that of this StackOverflow post and so I adapted the last comment so that it uses a POST request including the &confirm=t parameter. This can be verified by trying to download one of the models. Swapping to a library may be preferred for long-term support.

Separately, the installation with Docker would not run due to an error on import cv2. This appears to due to a change in opencv-python since requirements.txt was uploaded. This fixes that error by forcing all of the opencv-python dependencies to version 4.5.4.58 which was the current version as of Nov 12, 2021 when requirements.txt was originally committed. I do not know that this is the correct version, but it resulted in a working build for me.