NVlabs / instant-ngp

Instant neural graphics primitives: lightning fast NeRF and more
https://nvlabs.github.io/instant-ngp
Other
16.03k stars 1.93k forks source link

Support for OpenCV fisheye model #1063

Open cpkcpkcpk opened 2 years ago

cpkcpkcpk commented 2 years ago

Hi!

Would it be possible to add support for Colmap's OpenCV fisheye model?

I've been getting good results with an 8mm fisheye lens and Nerfstudio's nerfacto method which does support it, and would love to use the same datasets with NGP.

Thanks!

dong-won-shin commented 2 years ago

you'd better check the SILVR dataset for fisheye setup. https://idlabmedia.github.io/large-lightfields-dataset/#download

cpkcpkcpk commented 2 years ago

Thanks for the link. I have been defishing the images to use them with NGP, but it would be great to skip this step if possible.

arbab-ml commented 1 year ago

@cpkcpkcpk can you please tell me how the images of your dataset looks? Are they fisheye images, circular, with black shade all around Or some other format? Thanks,

cpkcpkcpk commented 1 year ago

I use a few different fisheye lenses, so both formats. 8mm lens on my mirrorless camera is rectangular fisheye images, 4mm lens and Insta360 are circular with black border.

I get better results with the 8mm, but when using circular I add image masks to ignore the black border.

Also since I posted this, support for Colmap’s fisheye model has been added, so no need to defish images first.

On Mon, 3 Apr 2023 at 01:16, arbab97 @.***> wrote:

@cpkcpkcpk https://github.com/cpkcpkcpk can you please tell me how the images of your dataset looks? Are they fisheye images, circular, with black shade all around Or some other format? Thanks,

— Reply to this email directly, view it on GitHub https://github.com/NVlabs/instant-ngp/issues/1063#issuecomment-1493482203, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFZLVOG2GVTERXUCUTGGPJLW7IJGPANCNFSM6AAAAAAR37IP7I . You are receiving this because you were mentioned.Message ID: @.***>

arbab-ml commented 1 year ago

thanks @cpkcpkcpk . that's very helpful. Best,