CMake: corrections - Githubissues

NVlabs / instant-ngp

Instant neural graphics primitives: lightning fast NeRF and more

https://nvlabs.github.io/instant-ngp

Other

16.03k stars 1.93k forks source link

CMake: corrections #1473

Open scivision opened 1 year ago

scivision commented 1 year ago

to set default build type, it must be done before project()
use simpler list(APPEND to avoid typos
use generator expressions rather than CMAKE_C_FLAGS
correct use of definitions instead of options