search

NVlabs / mimicgen

This code corresponds to simulation environments used as part of the MimicGen project.
Other
285 stars 45 forks source link

Function undefined #23

Closed yunshengtian closed 2 weeks ago

yunshengtian commented 3 weeks ago

Hi, thank you for releasing the great repo!

It seems like this function (visualize_trajectory_with_obs) is undefined in visualizing subtasks: https://github.com/NVlabs/mimicgen/blob/ea0988523f468ccf7570475f1906023f854962e9/mimicgen/scripts/visualize_subtasks.py#L258C13-L258C42

Could you fix it? Much appreciated.

amandlek commented 3 weeks ago

I believe I have fixed the issue - can you verify it works for you? See this PR. If it works I will go ahead and merge it.

yunshengtian commented 3 weeks ago

Hi @amandlek thanks for your prompt response! I think there are still variables undefined here (stage_signal and vis_stage_inds) in the updated function https://github.com/NVlabs/mimicgen/blob/9922b6be2b3de92e08a7f678ad058b8ef836960f/mimicgen/scripts/visualize_subtasks.py#L140

amandlek commented 3 weeks ago

Sorry about that - updated.

yunshengtian commented 2 weeks ago

Awesome. Thank you so much!

amandlek commented 1 week ago

Addressed by #24