search

NVlabs / nvbio

NVBIO is a library of reusable components designed to accelerate bioinformatics applications using CUDA.
BSD 3-Clause "New" or "Revised" License
206 stars 50 forks source link

Enable building nvbio with cuda10 and runable on Volta #19

Closed vmiheer closed 5 years ago

vmiheer commented 6 years ago

Also add alternate repo.

r-barnes commented 6 years ago

This looks like a really great notice to add. It seems to be true and the compilation difficulties are otherwise difficult to debug. Unfortunately, the ngstools repo no longer exists.

r-barnes commented 5 years ago

@vmiheer : Is there any way to change the title of this pull request to make it more informative? If not, perhaps we should close the request and build a new one?

vmiheer commented 5 years ago

@r-barnes, does this look okay? Otherwise please suggest alternative I can modify 😃 .

r-barnes commented 5 years ago

@vmiheer : This looks much better. I think the only other problem is that we have your continuous integration commit on this PR. Ideally, we should build a separate branch on our repo and remove that specific change, and any others which wouldn't immediately translate to Nvidia, though this is the only one I can think of. That branch, which we could call upstream_pr or similar would then be the one we'd use for the PR.

r-barnes commented 5 years ago

@vmiheer : Actually, could you close this pull request? I'll make a new one from upstream_pull_request.

Nvidia is changing who owns the NvBio project and it turns out I know the new owner, so it might streamline the pull if I'm able to manage it.