NVlabs / nvbio

NVBIO is a library of reusable components designed to accelerate bioinformatics applications using CUDA.
BSD 3-Clause "New" or "Revised" License
206 stars 50 forks source link

tiny bug in fasta_inl.h #31

Closed igorchern closed 4 years ago

igorchern commented 4 years ago

Big thanks to authors! Great project. There is a small bug which might be left unnoticeable unless you hit it accidentally: nvbio/fasta/fasta_inl.h : 93 If code exits at condition (n == n_reads) when hitting the then it will miss the sequence on next iteration because the file pointer will be past over the . The correct exit clause would be: if (n == n_reads) { m_buffer_pos--; return n; }