search

NVlabs / nvdiffrec

Official code for the CVPR 2022 (oral) paper "Extracting Triangular 3D Models, Materials, and Lighting From Images".
Other
2.09k stars 222 forks source link

util.rotate_x seems inverse from gl's right hand rule #152

Closed 2226415223 closed 6 months ago

2226415223 commented 6 months ago

as mentioned above, is it a mistake from other diffrential project so you have to negtive all the x angle before pass to util.rotate_x, the following is the correct matrix image

jmunkberg commented 6 months ago

Thanks for highlighting this @2226415223 !

Yes, as you mention, this is an issue we inherited from nvdiffrast https://github.com/NVlabs/nvdiffrast/blob/main/samples/torch/util.py#L28

Fixed in CL a3e7390