search

NVlabs / nvdiffrec

Official code for the CVPR 2022 (oral) paper "Extracting Triangular 3D Models, Materials, and Lighting From Images".
Other
2.09k stars 222 forks source link

`groupshared` is not supported in slangtorch. #158

Open saedrna opened 1 month ago

saedrna commented 1 month ago

Hi there, groupshared float4x4 mtx; in mesh.slang does not compile (as below). I am using the The latest slangtorch version in pip. I am not familiar with slang lang, but it seems that groupshared is similar to block-wise shared memory in CUDA. I think this should be absolutely supported by CUDA.

renderutils\mesh.slang(51): error 31201: modifier 'groupshared' is not allowed here.       
    groupshared float4x4 mtx;

I am not sure if this is the version difference, because recently slangpy has been renamed to slangtorch.

Han

jmunkberg commented 1 month ago

Thanks for reporting @saedrna .

I have upgraded the slang branch to use slangtorch instead of slangpy and fixed the groupshared issue you reported above. Fix in CL e6c1589f53f2b83529662ba96f85f8c8f0eca433