Hyphens to underscores in YAML keys

NVlabs / timeloop

Timeloop performs modeling, mapping and code-generation for tensor algebra workloads on various accelerator architectures.

https://timeloop.csail.mit.edu/

BSD 3-Clause "New" or "Revised" License

303 stars 99 forks source link

Hyphens to underscores in YAML keys #239

Closed tanner-andrulis closed 5 months ago

tanner-andrulis commented 5 months ago

Changed because:

Previous version was inconsistent (used underscores in some places, hyphens in others)
Hyphens are ambiguous in math expressions (is "a-b" a hyphenated variable or a subtraction)

angshuman-parashar commented 5 months ago

src/compound-config/hyphens-to-underscores.cpp:59:23: error: implicit instantiation of undefined template 'std::basic_stringstream<char>'
    std::stringstream buffer;
                      ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/iosfwd:146:32: note: template is declared here
    class _LIBCPP_TEMPLATE_VIS basic_stringstream;

tanner-andrulis commented 5 months ago

Try it out now. This error does not appear on my system so I'm blind to the results, but I believe this will work