Closed gilbertmike closed 3 weeks ago
Build fails on MacOS Ventura 13.6.6, Macbook Pro M1, clang version 14.0.3 (clang-1403.0.22.14.1), target arm64-apple-darwin22.6.0.
Log attached. log.txt
This seems to be caused by the way I'm including symbols in the libraries. I've included the application symbols in timeloop-mapper
. Would you mind trying again now?
src/applications/mapper/mapper.cpp:395:41: error: use of undeclared identifier 'oaves_prefix'
oaves_prefix,
^
It looks like a bunch of output file names (around line 366) disappeared.
Yes, I thought I moved all the file printing away since PyTimeloop stopped crashing, but I realized MapperThread
also does a bunch of printing. Somehow these do not crash PyTimeloop so I did not catch them at first. I'm looking into it.
Regression test passed. Merging.
Include the Mapper and Model applications in a new library by:
Application
toapplication::Mapper
orapplication::Model
to avoid name collision. This also adds theapplication
namespace.timeloop-applications
.Note that code that links to
timeloop-applications
also needs to link totimeloop-mapper
.Known Issues
Run()
that writes to files and just don't call that in the Python version.