NVlabs / trajdata

A unified interface to many trajectory forecasting datasets.
Apache License 2.0
311 stars 38 forks source link

Current status / development schedule of trajdata #3

Closed Leon0402 closed 2 years ago

Leon0402 commented 2 years ago

I'm opening this up as a response to my two other closed tickets because I'm unsure if you receive notifications for these.

First of all, thank you for your quick and detailed response. Good to hear that both issues are at least partially already addressed internally.

I'm currently evaluating whether I use this software for my current project for my bachelor thesis. As this will happen in the following weeks, I would be thankful for some insights regarding the schedule of this project.

My goal is to use it for trajectron++ with some custom dataset. I will experiment with this library in any case because I think this is the way to move forward (at least in the long term). Some additional insight help me evaluate if the library might be used already now (within this month) or if it's something to watch out for in the long term rather. Thanks for your help! Very appreciated!

BorisIvanovic commented 2 years ago

Hi @Leon0402 , thanks again for your interest (and for the pull request!) in the project! Let me try and answer your questions below...

Hopefully these answer your questions!

Leon0402 commented 2 years ago

Hi @BorisIvanovic, thank you for the very detailed answer and insights. Based on this and my own experiments I decided to stick with the library. Not everything works perfectly yet (obviously), but I see it as a huge improvement compared to all manual converting scripts, evaluation scripts and other stuff.

Just a quick note on one of your comments:

The development of the library is still going on internally, and I periodically sync changes between the internal and external versions (I don't plan for them to go out of sync for longer than a week or so). The core idea I have in mind is that any changes or new features are first beta-tested by us internally before rolling out the (hopefully) more stable code externally.

I see the idea behind this. But I think it would be very helpful to even upstream the internal main branch on a separate development / alpha development branch or something like that. This way users (me as of now :-)) see what bugs you already found / fixed. This avoid me opening up issues or Pull Request for things you already fixed. This might be especially helpful at this early stage, where there are more features / bug fixed to come.

BorisIvanovic commented 2 years ago

First of all, thank you for the vote of confidence! I'm glad to hear you plan to continue using this :)

Regarding synchronizing changes: I like the idea in theory, unfortunately I don't know if it can be done in practice. The only reason I say this is because I don't believe it is possible for me to automatically mirror our internal repo with this public repo since they are hosted on separate services (we do not use GitHub internally).

Having said that, I will do my best to be vigilant and ensure that any bugs we fix or features that we implement internally are quickly brought out publicly!

Leon0402 commented 2 years ago

Some providers include functionality for that. For instance syncing from GitLab to Github is quite easy. Others might have similar solutions. I think there are a few though that don't support it natively like Azure Devops. Having said that, it should be quite easy to implement it via a pipeline.

Having said that: I'm very thankful that new features / bug fixed arrive so quickly as well as responses to open issues / PRs. It's awsome to wake up in the morning (european timezone) and see new progress :-)