search

NVombat / MusicApp

Karaoke Music App created for the JTV Foundation to host Karaoke Videos and allow users to record voice tracks and videos, upload and download the media. (https://www.vr1movement.com/)
https://www.vr1music.com/
MIT License
8 stars 10 forks source link

Add Likes & Comments Option For Posts #111

Open NVombat opened 2 years ago

NVombat commented 2 years ago

Detailed description

As of now the posts are displayed on the POSTS page and the user can see other user's posts. Once the front end develops a custom video/audio player to show the posts, we want to add the feature of having Likes & Comments for each post. The comments may be filtered (No swear words etc) and can also have a nested structure where replies can be shown (How it is shown on Instagram and Facebook).

In addition to this the admin should be allowed to delete any comments if they are not detected by the filter. That way there is a method to regulate the content.

Context

This will improve the user experience and make it more than just a platform for sharing media by enabling users to interact rather than just post and view other user's posts.

Possible implementation

Add additional columns to the Database for a count of likes & a store for comments which can be updated as and when the user receives any likes or comments. The comments can be stored in a list or dictionary nested within the post data

Add a functionality for the admins to delete the comments which is a simple delete operation in the database.

For Filtering of Comments, we can either use a simple model to detect bad words from a list of predefined bad words or even have a machine learning model which filters comments.

github-actions[bot] commented 2 years ago

Hello, Thank You for raising this Issue. Our Team will look into the issue and discuss with you.

Vrbitko commented 2 years ago

Hello, is this issue still available? Thanks

NVombat commented 2 years ago

Hello, is this issue still available? Thanks

Yes the issue is available. Let me know if you wanna take it up

Vrbitko commented 2 years ago

Yes sure, will take it.

NVombat commented 2 years ago

Yes sure, will take it.

Perfect, if you need any assistance feel free to reach out... Will help you wherever I can

NVombat commented 2 years ago

Hey, are you working on the server or client side? Or are you working on both? Also can you send me a list of exactly which env values you need?

Best,

Nikhill Vombatkere

On Wed, 19 Oct 2022 at 01:22, Vrbitko @.***> wrote:

Hello, im getting issues w .env setup. Can you somehow share .env file w me? Having problems w db setup but also others env variables. THX

— Reply to this email directly, view it on GitHub https://github.com/NVombat/MusicApp/issues/111#issuecomment-1282926737, or unsubscribe https://github.com/notifications/unsubscribe-auth/APGKMCAPAMJMYSJ24JSITPTWD35XRANCNFSM5PBVBWXQ . You are receiving this because you authored the thread.Message ID: @.***>

Vrbitko commented 2 years ago

Hey! Im on BE but also tried to run FE. Will update you during the week w databases diagrams so you will agree on changes about coments and likes. Also had problems w running the project. Have you been thinking w updating readme/docker? Currently I've already checked code and I am ready to start.

Vrbitko commented 2 years ago

The problem with envs - currently solved, if any issue will occure, will write you, thx

NVombat commented 2 years ago

Alright great. Yeah that would be great. Let me know what env variables you need and stuff. Okay let me have a look and tell you how to run it. Yeah a few updates are needed and I'll do that soon. Just keep me in the loop

On Thu, 20 Oct 2022, 00:20 Vrbitko, @.***> wrote:

Hey! Im on BE but also tried to run FE. Will update you during the week w databases diagrams so you will agree on changes about coments and likes. Also had problems w running the project. Have you been thinking w updating readme/docker? Currently I've already checked code and I am ready to start.

— Reply to this email directly, view it on GitHub https://github.com/NVombat/MusicApp/issues/111#issuecomment-1284435800, or unsubscribe https://github.com/notifications/unsubscribe-auth/APGKMCGTQZLZN2PX7BJ4DCDWEA7GRANCNFSM5PBVBWXQ . You are receiving this because you authored the thread.Message ID: @.***>

Vrbitko commented 2 years ago

So, i would suggest something like that: image

  1. suggestion: From my point of view its better NOT TO USE DICTS as you suggested. Would love to implement it using https://pydantic-docs.helpmanual.io/ and create own models so there will be implemented better typing for the future.
  2. suggestion: i saw that you are using email of user as foreign key. Is there reason for that? Cannot you just use PID of user? At the photo i used that pid as FK.

Thank you

NVombat commented 2 years ago

Hey,

The diagram looks great. As for the suggestion to use Pydantic, I like it a lot and would love to implement it. I developed this a while back and may not have a reason to use the email as a key. Since you have found these issues, let's set up a meeting and we can discuss this further? Is that suitable for you?

Best,

Nikhill Vombatkere

On Fri, 21 Oct 2022 at 04:07, Vrbitko @.***> wrote:

So, i would suggest something like that: [image: image] https://user-images.githubusercontent.com/36973527/197071438-4ea4b6b2-7fb3-4a3f-9ada-9bc98dc36e34.png

  1. suggestion: From my point of view its better NOT TO USE DICTS as you suggested. Would love to implement it using https://pydantic-docs.helpmanual.io/ and create own models so there will be implemented better typing for the future.
  2. suggestion: i saw that you are using email of user as foreign key. Is there reason for that? Cannot you just use PID of user? At the photo i used that pid as FK.

Thank you

— Reply to this email directly, view it on GitHub https://github.com/NVombat/MusicApp/issues/111#issuecomment-1286235213, or unsubscribe https://github.com/notifications/unsubscribe-auth/APGKMCCQFOP556TWCGZ63PTWEHCTRANCNFSM5PBVBWXQ . You are receiving this because you authored the thread.Message ID: @.***>

Vrbitko commented 2 years ago

Yes sure it is! Which platform for calls do you prefer? Can we meet tomorrow 16:00 CET?

NVombat commented 2 years ago

Sounds good.

Best,

Nikhill Vombatkere

On Sat, 22 Oct 2022 at 02:56, Vrbitko @.***> wrote:

Yes sure it is! Will write you email.

— Reply to this email directly, view it on GitHub https://github.com/NVombat/MusicApp/issues/111#issuecomment-1287450748, or unsubscribe https://github.com/notifications/unsubscribe-auth/APGKMCB434WELASCL3LPMBLWEMDAHANCNFSM5PBVBWXQ . You are receiving this because you authored the thread.Message ID: @.***>

Vrbitko commented 2 years ago

@NVombat I've sent you invite to linkedin, we can agree on call there. It will be faster.

NVombat commented 2 years ago

That sounds good to me.

Best,

Nikhill Vombatkere

On Mon, 24 Oct 2022 at 01:44, Vrbitko @.***> wrote:

@NVombat https://github.com/NVombat I've send you invite to linkedin, we can agree on call there. It will be faster.

— Reply to this email directly, view it on GitHub https://github.com/NVombat/MusicApp/issues/111#issuecomment-1288191578, or unsubscribe https://github.com/notifications/unsubscribe-auth/APGKMCAGRPWO2FTHLM7MWLLWEWMBXANCNFSM5PBVBWXQ . You are receiving this because you were mentioned.Message ID: @.***>

NVombat commented 2 years ago

Hey, I wont be able to share any credentials but I have added a little setup part in the server/README.md file so you can set up your own env