search

NWACus / avy

Mobile-Native Viewing of NAC Avalanche Forecasts
MIT License
10 stars 6 forks source link

Tab Headers Misaligned When Long Custom Names Used #362

Open stevekuznetsov opened 11 months ago

stevekuznetsov commented 11 months ago

The ACs can configure what they want to call their conditions blog, and when it's a long name, things get goofy.

Screenshot_20230921-071250

stevekuznetsov commented 11 months ago

cc @floatplane

floatplane commented 11 months ago

thoughts

  1. is this new functionality? when did we start adding a conditions blog tab?
  2. how we fix this is probably a design question first (do we shrink the text, chop the text, make the tab list scroll horizontally, use something like a dropdown instead of a tab control...)
  3. we should label these as v.next or someday or something so it's easier to manage the list of issues - IIUC this does not apply to NWAC or SNFAC
stevekuznetsov commented 11 months ago

is this new functionality? when did we start adding a conditions blog tab?

Not sure, git blame would help - likely added by me this spring.

how we fix this is probably a design question first

Agreed!

we should label these as v.next or someday or something so it's easier to manage the list of issues - IIUC this does not apply to NWAC or SNFAC

Both NWAC and SNFAC use conditions blogs, so I think it might?

stevekuznetsov commented 11 months ago

But sure - maybe we can add milestones to the repo and add issues to those?

stevekuznetsov commented 11 months ago

Screenshot_20230921-101340

Here's the issue for SNFAC

floatplane commented 11 months ago

For this particular case, I feel like we should put “Conditions Blog” behind a flag or env var for now, because I do think it needs some thought:

  1. the SNFAC conditions blog entries contain videos which we’re not showing in app. the text alone is pretty boilerplate and doesn't tell you much (example https://www.sawtoothavalanche.com/forecasts/#/post/120510)
  2. the Conditions Blog is center-wide, while the other tabs are specific to the zone you’re looking at. Design is probably going to say that’s confusing from an information hierarchy standpoint (I think I’d agree). Conditions blog also updates at a slower cadence then the other forecasts. A notification center is maybe a better place for these to show up.
stevekuznetsov commented 11 months ago

Bizarre - the API calls are per-zone just like forecasts, etc. Fine to defer for later, but probably good to tackle this. The website shows these alongside weather for forecast pages and parity there is likely what we want.

floatplane commented 11 months ago

I opened an Asana task to decide where this should live in the app and how it should be designed: https://app.asana.com/0/1203665433773397/1205571683359958. Let's figure that out before trying to make changes to the tab headers!