search

NWACus / avy

Mobile-Native Viewing of NAC Avalanche Forecasts
MIT License
13 stars 7 forks source link

Polygon tap targets are inconsistent #48

Open floatplane opened 1 year ago

floatplane commented 1 year ago

When trying to tap Snoqualmie Pass, I'm getting about a 50% hit rate - the other 50% seem to be divided between West Slopes South and West Slopes Central.

I found an excellent bug report here that seems to describe a similar problem: https://github.com/react-native-maps/react-native-maps/issues/3280. The bug was never addressed, and ultimately closed.

I think we may need to do some kind of point-in-polygon check as described in that bug report.

stevekuznetsov commented 1 year ago

Yep, sorry, should have written this down - found it way back in the day. Look at the usage of d3.geoContains() for finding the zone that pertains to an observation - we will want that logic for taps as well, but likely that will force us to figure out why that method seems buggy - I worry the polygon definitions are somehow leaky.