NWACus / avy

Mobile-Native Viewing of NAC Avalanche Forecasts
MIT License
11 stars 6 forks source link

Implement final(?) campaign designs, get modal working over map #638

Closed floatplane closed 9 months ago

floatplane commented 9 months ago

This should be basically ready to go now, I think. Feature flag is still off so merging it should be safe.

All the buttons and whatnot are wired up and sending events.

map list
Simulator Screen Recording - iPhone 14 Pro Max - 2023-12-17 at 14 45 40 Simulator Screen Recording - iPhone 14 Pro Max - 2023-12-17 at 14 54 10
stevekuznetsov commented 9 months ago

@floatplane in a conversation with Charlotte last week she had mentioned only showing the map modal once per user - so dismissing it would be final for the campaign. Did we change that to once every eight hours? I think in practice that would mean almost every time someone opens the app

floatplane commented 9 months ago

@floatplane in a conversation with Charlotte last week she had mentioned only showing the map modal once per user - so dismissing it would be final for the campaign. Did we change that to once every eight hours? I think in practice that would mean almost every time someone opens the app

I had a conversation with here where she said once per day. I'm assuming this isn't finalized yet!

tl;dr we can support whatever. for showing once, we just increase the frequency so high that it can't be shown more than once before the end of the campaign cycle.

stevekuznetsov commented 9 months ago

Sounds good! Do you want to wait on anything else with this PR? The code looks good, we can merge it as it is I think

floatplane commented 9 months ago

thanks for taking a look! merging now