search

NWACus / avy

Mobile-Native Viewing of NAC Avalanche Forecasts
MIT License
10 stars 6 forks source link

package.json: fix unmet peer dependencies #676

Closed stevekuznetsov closed 7 months ago

stevekuznetsov commented 7 months ago

The GraphQL schemas we were working with are not useful anyway.

stevekuznetsov commented 7 months ago

Fixes #342

stevekuznetsov commented 7 months ago 
The package "expo-modules-autolinking" should not be installed directly in your project. It is a dependency of other Expo packages, which will install it automatically as needed.
The package  "@types/react-native" should not be installed directly in your project, as types are included with the "react-native" package.
One or more checks failed, indicating possible issues with the project.

lol. OK, whatever

beaucollins commented 7 months ago

You may need to nuke the current modules and do a clean install:

rm -fr node_modules
yarn install --frozen-lockfile
beaucollins commented 7 months ago

I'll double check console messages with what I've got.

stevekuznetsov commented 7 months ago

Thanks, ran that locally. The jest errors reproduced in CI - maybe we also need to cache-bust the module cache in actions?

beaucollins commented 7 months ago

A changing yarn.lock should invalidate the cache https://github.com/actions/setup-node#caching-global-packages-data

stevekuznetsov commented 7 months ago

Hm - well, if you don't see any downsides to having the extra mocks and ts-node in the dev dependencies, maybe nothing to do here?