search

NWACus / avy

Mobile-Native Viewing of NAC Avalanche Forecasts
MIT License
13 stars 7 forks source link

When Panning Map, Don't Move the Pin Every Time #747

Open stevekuznetsov opened 6 months ago

stevekuznetsov commented 6 months ago

This is specifically on the obs submit form, when picking location for where the obs is coming from. Right not the Pin will move each time you touch the map with one finger.

kevinherdez commented 2 months ago

I have a fix for this, but when working on it I came across some user experience things that maybe could be improved on. I wanted to get feedback before making the changes though.

Right now, it's not clear that closing the modal with the X button is going to erase the location as well. I think the standard practice is that it should close out, and keep everything as it was. I think we can make this more clear in 2 ways.

1) Add another button to the modal (like an eraser or trash can) that the user presses to clear the pin on the map, they would then hit the checkmark to save the clear

2) Add a "Clear location" button under the location form field, if the user has a location set

Let me know what you think. I'm also fine leaving it as is. It was just something that I found a little wonky when debugging this.

yuliadub commented 2 months ago

@kevinherdez these are fair points!

a little history on the view: at first, we only had the check mark and you could only select the location and there was no way to clear it. when we added the ability to clear, we went back and forth on this quite a bit (if the X made sense/etc, if it should be a different icon, we havent considered having the clear button outside or the map as far as I remember since we didnt want to make major changes to the obs form itself), and in the end the consensus was it would be good to get a design opinion on what user experience is best but we didn't at the time have a designer who can help out. With all that, totally open to changing it!

if you have a vision of how it may work better, and its not a lot of work, I'd say - put it together so we can play with it. If its more then minimum amount of work, lets hold off for now -- we may have some designer help later on as well, so it is possible this whole experience may need a redesign. will leave a tag for @charlotteguard to keep me honest :)

kevinherdez commented 2 months ago

That sounds good! I'll go ahead and make a separate issue for this.

kevinherdez commented 2 months ago

Made the new issue here #793