In theory every repo in the NWChemEx-Project organization has branch protection rules setup for the master branch (requires PRs, PRs need reviews, etc.). At one point we also specified via the GitHub API which CI workflows were required to pass before the PR is merged (for the record, all of the CI workflows need to pass before a PR should be merged). By specifying the required workflows as part of the branch protection rules, GitHub prevents us from accidentally merging a PR with failing workflows. Right now all of the workflows run, but if you're not careful, you can actually merge the PR with failing workflows.
In setting the required workflows, GitHub uses the names of the workflows. The problem previously was that somehow the names changed and so GitHub was waiting forever for non-existent workflows to run. To avoid the PRs being in limbo we dropped the required workflows. This issue is for resetting the branch protection rules so that they enforce the workflows passing using their current names (and hopefully figuring out a way to future proof the names so we don't have to go through this again).
In theory every repo in the NWChemEx-Project organization has branch protection rules setup for the master branch (requires PRs, PRs need reviews, etc.). At one point we also specified via the GitHub API which CI workflows were required to pass before the PR is merged (for the record, all of the CI workflows need to pass before a PR should be merged). By specifying the required workflows as part of the branch protection rules, GitHub prevents us from accidentally merging a PR with failing workflows. Right now all of the workflows run, but if you're not careful, you can actually merge the PR with failing workflows.
In setting the required workflows, GitHub uses the names of the workflows. The problem previously was that somehow the names changed and so GitHub was waiting forever for non-existent workflows to run. To avoid the PRs being in limbo we dropped the required workflows. This issue is for resetting the branch protection rules so that they enforce the workflows passing using their current names (and hopefully figuring out a way to future proof the names so we don't have to go through this again).