search

NWChemEx / .github

GitHub Settings for the NWChemEx Organization
https://nwchemex.github.io/.github/
Apache License 2.0
1 stars 2 forks source link

Use relative paths in __init__.py #32

Open ryanmrichard opened 2 years ago

ryanmrichard commented 2 years ago

Right now the __init__.py files generated by the CMake API use absolute paths for the headers and libraries which are set to the build directory. For installation purposes, these paths should be relative to an installation root (said root is usually a staging directory while building, and the actual installation root after install).

Off the top of my head I'm not sure where Python bindings are usually installed in a typical GNU build (lib maybe?), but I'm sure there's a precedent.

Since CMaize currently does not support installation, this is not a high-priority issue.

wadejong commented 2 years ago

This should be something we can simplify. But, this means we need to agree what the install looks like. We can install Python packages in the same location as the headers and binaries, and require PYTHONPATH to be set. If you want the python packages in the normal python location, we need to make sure both are synchronized.