search

NWChemEx / .github

GitHub Settings for the NWChemEx Organization
https://nwchemex.github.io/.github/
Apache License 2.0
1 stars 2 forks source link

Update cppyy #60

Closed keceli closed 1 year ago

keceli commented 1 year ago

TODO: .cmake files are not synced anymore, see issue #48. Should we enable sync or move them to a new repo or to CmakePP?

ryanmrichard commented 1 year ago

On second thought, I guess I didn't think the placement of these files through well. I think the easiest solution is to make a new repo NWXCMake (or something) which holds project-wide CMake modules. Then we can just fetchcontent that repo from other repos in the organization.

keceli commented 1 year ago

On second thought, I guess I didn't think the placement of these files through well. I think the easiest solution is to make a new repo NWXCMake (or something) which holds project-wide CMake modules. Then we can just fetchcontent that repo from other repos in the organization.

I am not a fan of adding a new repo in general and in this case it requires changes in each repo.

I'd prefer/vote for enabling sync. There might be other files (gitignore, code of conduct, contributing etc) that we would like to sync as well.

keceli commented 1 year ago

Or if possible, moving cmake modules to CMakePP.

ryanmrichard commented 1 year ago

We moved away from synch (at least the action we used before) because it didn't work well. GitHub seems to be very against repos triggering actions in other repos (it makes sense because you can imagine how that could turn into more or less a DDOS attack). In turn, it felt like we were always fighting GitHub to keep it running. Then there was the fact that quite often we had to manually trigger pushes to get it to work; I never did figure out what caused this need, but it very well could be related to the former point. At this point, I feel that needing to copy/paste (even if it's automated copy/paste) things is an anti-pattern and I'd like to avoid it.

CMakePP is intended to be a stand alone project, so I'm hesitant to put CMake modules there unless they are very general. The ones throughout NWX are pretty specific to our needs.

I guess I'm fine leaving the CMake modules in this repo. If we fetch-content this repo we'll get some extra stuff, but I don't think it's so much extra stuff to really impact performance.

ryanmrichard commented 1 year ago

Anyone else want to weigh in before we merge this?

ryanmrichard commented 1 year ago

@keceli was this superseded by creating the NWXCMake repo?

keceli commented 1 year ago

@keceli was this superseded by creating the NWXCMake repo?

Yes, should have closed it earlier.