Closed pdhung3012 closed 1 year ago
Thank you for your suggestion. I am working to move the caching before the get-libint function.
On Saturday, February 4, 2023, Ryan Richard @.***> wrote:
@.**** commented on this pull request.
In actions/get_dependencies/action.yaml https://github.com/NWChemEx-Project/.github/pull/69#discussion_r1096573414 :
- name: cache-libint
- id: cache
- uses: @.***
- with:
- path: |
- libint-2.6.0/
- install/
- key: libint-gcc${{ matrix.gcc_version }}
This does not seem like an appropriate place to put this logic since 90% of invocations of this action will not build libint. Can we factor out this logic and place it somewhere closer to the actual building of libint? This may require a special dispatch for libint, say to a special action.
— Reply to this email directly, view it on GitHub https://github.com/NWChemEx-Project/.github/pull/69#pullrequestreview-1284104612, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLTUPITVPW6NCPDEFXTRMLWV2Q2BANCNFSM6AAAAAAURJT6QI . You are receiving this because you authored the thread.Message ID: @.***>
-- Phan Đăng Hưng IT engineer Institution Of Science And Technology- Vietnam Academy Of Science And Technology Another email: @.*** Phone: 0983193089 Yahoo: swenteiger7 Skype: pdhung3012
I think what's here is better. I'm still a bit concerned about its generality, but we can tackle that later. For now, I think it's more important to start caching libint
PR Type
Brief Description
Not In Scope
PR Checklist
TODOs