search

NWChemEx / .github

GitHub Settings for the NWChemEx Organization
https://nwchemex.github.io/.github/
Apache License 2.0
1 stars 2 forks source link

Build parallelzone with image #90

Closed yzhang-23 closed 1 year ago

yzhang-23 commented 1 year ago

PR Type

Brief Description Action files to build ParallelZone with a pre-built docker image have been added. Now everything is hardwired for ParallelZone and repo choosing could be made automatically in the future.

Not In Scope

PR Checklist

TODOs

ryanmrichard commented 1 year ago

@yzhang-23 also this is a feature. The choices breaking, feature, patch map to major, minor, patch of the repo's version (for semantic versiioning).

ryanmrichard commented 1 year ago

🚀 [bumpr] Bumped! New version:v0.2.0 Changes:v0.1.1...v0.2.0

yzhang-23 commented 1 year ago

@yzhang-23 also this is a feature. The choices breaking, feature, patch map to major, minor, patch of the repo's version (for semantic versiioning).

Sorry. From no on I will list this CI check-ins as features.

ryanmrichard commented 1 year ago

They're features as long as you're adding new functionality; they're patches if you're just changing how things are done (and I'd argue that CI isn't part of our public API, so it's never breaking).

yzhang-23 commented 1 year ago

It looks like you more or less copy/pasted the existing CI, and then switched it over to using the image. Am I correct in assuming the plan is to repo by repo switch things over to the image-based version and then discontinue the non-image (i.e., VM versions)?

This LGTM, assuming that I correctly understood what you're doing here.

Yes, the plan is to update the CI repo by repo and finally retire the non-image-based CI for all repos.

yzhang-23 commented 1 year ago

They're features as long as you're adding new functionality; they're patches if you're just changing how things are done (and I'd argue that CI isn't part of our public API, so it's never breaking).

Got it! Thanks.