Closed yzhang-23 closed 1 year ago
🚀 [bumpr] Bumped! New version:v0.3.3 Changes:v0.3.2...v0.3.3
@yzhang-23 just in case you didn't get the email, merging this PR failed CI https://github.com/NWChemEx-Project/.github/actions/runs/4917078080
@yzhang-23 just in case you didn't get the email, merging this PR failed CI https://github.com/NWChemEx-Project/.github/actions/runs/4917078080
So, you triggered the action without modifying any docker files, right? It looks that the changed-files action dose not know how to deal with such a situation.
@yzhang-23 it was triggered by merging the PR. I didn't do anything (it's attributed to me because of how the workflow is setup)
@yzhang-23 it was triggered by merging the PR. I didn't do anything (it's attributed to me because of how the workflow is setup)
This is very weird, but does reflect something wrong in the "on" event of the action. Ideally, this changed-files action should not run if no docker files have been changed. I had tested it in my forked branches and confirmed that it was the case (no docker file change no action). Let me do some research.
@ryanmrichard Please see the screenshot above. It looks that the same commit had been pushed twice during the CI workflow: one by me, one by CI. This "v0.3.3" is for tagging, right? Maybe if I restrict the changed-files action to pushes on the master branch, it won't be triggered twice.
PR Type
Brief Description Rewrite the build_docker_image action in order to build a docker image for a general NWX repo (not hardwired to ParallelZone) when the corresponding docker file under Docker/ is changed. Now we only need to maintain those docker files.
Not In Scope Now we only build the docker image and push it to the NWX registry. To be safe a test build of the corresponding repo using is necessary before final pushing the image into the NWX registry. This feature should be added in the coming days.
PR Checklist
TODOs