NWChemEx / TensorWrapper

A type-erased wrapper around various tensor backends
https://nwchemex.github.io/TensorWrapper/
Apache License 2.0
0 stars 0 forks source link

Fix TensorWrapper #171

Open ryanmrichard opened 9 months ago

ryanmrichard commented 9 months ago

Changes to ParallelZone broke TensorWrapper. In particular:

yzhang-23 commented 8 months ago

The questions I need to answer in order to fix this issue are summarized as the following:

  1. Should we introduce initialization/finalization callbacks into the RuntimeView class in ParallelZone? Why do we need callbacks here? I should compare the cases with/without initialization/finalization callbacks.
  2. If the answer to Q1 is "yes", how to introduce initialization/finalization callbacks into the RuntimeView class? Introducing callbacks in ctors is easy, but is there a way to also introduce callbacks into dtors (under investigation)?
  3. Is it advantageous to write an initialize wrapper for every downstream repo beyond ParallelZone (open for discussion)?
ryanmrichard commented 8 months ago

These questions really pertain to ParallelZone and should be tackled there.

ryanmrichard commented 8 months ago

To clarify, I was more thinking that it's the documentation of PZ that should be updated with the design discussion you're talking about.

yzhang-23 commented 8 months ago

To clarify, I was more thinking that it's the documentation of PZ that should be updated with the design discussion you're talking about.

Sure. I will add the design discussions to PZ doc.