search

NWChemEx / Utilities

Generic, helpful C++ classes
https://nwchemex.github.io/Utilities/
Apache License 2.0
0 stars 1 forks source link

Fixed string toupper and tolower functions not compiling #106

Closed zachcran closed 2 years ago

zachcran commented 2 years ago

Status

Brief Description

In #105, I forgot to test the suggested changes that I accepted into the repo, and it was merged without the CI checks since they were not running. This should fix the compile issues in tolower_string and toupper_string. I tested the build locally after the changes; the code compiles now and unit tests pass!

zachcran commented 2 years ago

@ryanmrichard Do we need you to override the required tests that are not ever going to run?

ryanmrichard commented 2 years ago

@zachcran yeah it needs an admin override when the CI doesn't run. Do you make PRs from forks for other repos too?

zachcran commented 2 years ago

@ryanmrichard Yeah, I exclusively use forks to make PRs, except for one or two minor changes to README files.