NWNX / nwnx2-linux

Neverwinter Nights Extender 2 - Linux version
http://www.nwnx.org/phpBB2/
Other
43 stars 27 forks source link

tools: Add genplugin.sh #108

Closed jd28 closed 5 years ago

jd28 commented 8 years ago

This is a simple bash script for bootstrapping new 2.8 plugins.

niv commented 8 years ago

Could we not just get rid of all those pluginlink fields? Is anyone seriously using them?

As it stands now, noone cares about the author, licence or url embedded in the binary, and noone maintains proper version numbers. That stuff belongs into README.

virusman commented 8 years ago

The version field was originally added to have an ability to check whether a plugin exists and get its version (i.e. inside an NWScript system that relies on an NWNX plugin).

niv commented 8 years ago

Yeah, I'm aware. The thing is though, it's buried somewhere and optional, and noone sets it.

I'd propose a small refactor to get rid of all the chaff, and maybe just leave the version in. Then, as soon as I manage to PR my connect stuff, expose plugin versions to the server.

virusman commented 8 years ago

The rest of the metadata fields - yeah, they're not really useful at all.

virusman commented 8 years ago

Changing common plugin API structs will break all of the out-of-tree plugins out there. If the core is going to be rewritten anyway, I think it'd be nicer to do all of the breaking changes at once, or, alternatively, make a development branch and do all of the core refactoring there.

jd28 commented 8 years ago

Ok, I've updated this to default to version 1.0.0. Also updated the usage to indicate that PascalCase is expected as the parameter and to convert that to dash-cash and snake_case where those seem to be the common convention.

jd28 commented 5 years ago

No point in this being here anymore.