search

NWTlter / NWT_CLM

Workflow scripts for running point simulations of CLM at Niwot Ridge using Tvan forcing data
1 stars 7 forks source link

Beta NWT_CLM Scripts #2

Closed hhollandmoritz closed 3 years ago

hhollandmoritz commented 4 years ago

@wwieder a repository for your perusal.

There are 5 scripts, a set of CLM instructions, and a Readme file for the user describing all of the scripts and the workflow.

The most complete and well-thought out files are CLM_instructions.md, flow.lter.clm.R, and supplemental_cleaning.R. The post-processing scripts are newer and I have had less time to troubleshoot them. As a result, they don't have as many bells and whistles and probably are more buggy than the pre-processsing scripts.

wwieder commented 4 years ago

I may have more reviews, but ended up just changing things in the PRs I've made

hhollandmoritz commented 3 years ago

@wwieder Lots of changes here. The biggest and most important is that I implemented the ability to run multiple vegetation types through flow.sim.R at once. I also fixed some of the smaller line-by-line comments you had from earlier, and added diel obs-vs-sim scatter plots to the comparison plotting.

I tried moving the timestamp backwards by one in the simulation data, it does look better but not by much.

Finally, I fixed some of the aesthetics of the plots where panels were in weird order.

Oh, and there's also snow_depth plotting now. (I can't remember if that was there before or not), but it's there and because you can run multiple vegetation communities through flow.sim.R, you can now compare snow depths across veg. communities in the comparison plotting script.

hhollandmoritz commented 3 years ago

I just added a "script status" section for each script in the workflow. Hopefully this will make it more easy to identify what needs to be done to improve the workflow going forward. (Though it's no substitute for the "Issues" tab on github).

wwieder commented 3 years ago

merge beta back into main