search

NWTlter / NWT_CLM

Workflow scripts for running point simulations of CLM at Niwot Ridge using Tvan forcing data
1 stars 7 forks source link

relative humidity always 100% #30

Closed wwieder closed 2 years ago

wwieder commented 2 years ago

The latest simulations I've been doing with CLM have really high GPP. I also noticed that relative humidity on the input data is always 100%. It looks like the data being read into prepare_forcings_for_clm.R have rH > 100%, plot below image

These input data (generated 2021-03-02) came from files for E and W towers *_flux_P_reddyproc_cleaned.txt
I'm wondering if this issue was generated with this code block https://github.com/NWTlter/NWT_CLM/blob/d9300fce8f1941a072b7c7eb7527272ca99626f3/clean_tvan_data.R#L454

which came in with this commit in Nov 2020 https://github.com/NWTlter/NWT_CLM/commit/c3ee346faa0b755e15e2b3ad8a2f61aebc6c9f48

I think the rH values may already be in %, so the values here are 100x larger than they should be.

hhollandmoritz commented 2 years ago

@wwieder I vaguely remember going back and forth on this and that at one point we had the opposite issue (?) and so I changed the values to % based on a meeting we had with John and @scelmendorf. It would be good to know for sure what rH is being recorded in.

katyarjay commented 2 years ago

The rH values were already converted to % in the tvan_L1_preprocess.R script, so the values ended up being 100x too large when multiplied by 100 again in the clean_tvan_data.R script. These lines will be removed from the clean_tvan_data.R script.

wwieder commented 2 years ago

closed by #33