search

NX-Editor / NxEditor.EpdPlugin

EPD plugin for NX-Editor
GNU Affero General Public License v3.0
3 stars 1 forks source link

Fix issue where material icons for SarcEditorView did not work properly #8

Closed bastuijnman closed 1 year ago

bastuijnman commented 1 year ago

When building the plugin in isolation (I'm building these in completely separate folders from the NxEditor repo itself, dunno if it works out of the box when doing something like that) it fails due to not having a proper reference to the Material icons & the IconProvider.

This addresses that issue and uses the standard mdi prefix for icons (the icons I chose are not great but couldn't find anything that gives a 1-1 replication of the default text editor find/replace icons).

ArchLeaders commented 1 year ago

This icons for this are from a custom provider: https://github.com/NX-Editor/NxEditor.EpdPlugin/blob/master/src/Providers/UI/MaterialSymbolIconProvider.cs

This works fine on my end, so I'm not really sure what the issue is. Are you synced with master?

ArchLeaders commented 1 year ago

Ah, found the issue. I forgot to commit the namespace reference to the ui providers.

bastuijnman commented 1 year ago

I see, no clue why I didn't spot the custom icon provider. Pulled main branch and works now.