search

NXP / i3c-slave-design

MIPI I3C Basic v1.0 communication Slave source code in Verilog with BSD license to support use in sensors and other devices.
Other
114 stars 35 forks source link

"i3c_time_control" module is missing #33

Open huangluyang0 opened 2 years ago

huangluyang0 commented 2 years ago

Dear IP owner, when I tried to use i3c_auton_wrapper with "ENA_TIMEC" parameter enabled, which means that I wanted to enable the Timing control/Timestamping feature, it turned out that "i3c_time_control" module is missing, I think that module is necessary for i3c slave timing control, like sc1/sc2/timec_ibi_byte. I'll really appreciate it if you can also include the "i3c_time_control" module in the package, thanks!!!

tsuhuai commented 2 years ago

I have built a simple 'i3c_time_control.v'. Can I upload it here? Also, I found a small issue in slave engine when using this i3c_time_control.v. line 558 of slave engine, next_state (when state == ST_IBI9TH) should be modified.

pkimelman-nxp commented 2 years ago

Please create a contrib directory for that. It needs to be clear it is sourced from elsewhere and that we have not checked it.

tsuhuai commented 2 years ago

Should I pull a request when I finished it?