NXTS-Developers / MOFHY-Lite

MOFHY Lite is a free web hosting management system to manage MOFH hosting accounts and SSL certificates.
https://getmofhy.eu.org
MIT License
20 stars 14 forks source link

mysqli_real_escape_string Cant fully prevent SQL Injection #103

Open 0944-tw opened 2 years ago

0944-tw commented 2 years ago

mysqli_real_escape_string CAN PREVENT SQL Injection BUT it cant FULLY PREVENT SQL Injection. So,Its Safe But Unsafe? xD https://stackoverflow.com/questions/5741187/sql-injection-that-gets-around-mysql-real-escape-string

0944-tw commented 2 years ago

Fo FIx It (Copied From Stackoverflow xD) Use Modern Versions of MySQL (late 5.1, all 5.5, 5.6, etc) AND mysql_set_charset() / $mysqli->set_charset() / PDO's DSN charset parameter (in PHP ≥ 5.3.6) Or Don't use a vulnerable character set for connection encoding (you only use utf8 / latin1 / ascii / etc)

mahtab2003 commented 2 years ago

Mofhy is expired

greenreader9 commented 2 years ago

Wait, so you are no longer supporting it, again?

ghost commented 2 years ago

Mofhy is expired

🤦

jaikt commented 2 years ago

🙄

mahtab2003 commented 2 years ago

This time it is permanently closed and will no longer receive any updates from vendor

jaikt commented 2 years ago

why bro?

mahtab2003 commented 2 years ago

There are some issues i can't resolve either.

jaikt commented 2 years ago

what are the issues? the community is there 🤔

0944-tw commented 2 years ago

yep

0944-tw commented 2 years ago

its easy to resolve :) just use PDO

mahtab2003 commented 2 years ago

Xss and some tokenized system issue. I'm thinking to make a new application based on codeigniter in order to make it work smoother and secure.

greenreader9 commented 2 years ago

Go for it!

jaikt commented 2 years ago

tokenized system issue

Like what? I would love to try fix it!

greenreader9 commented 2 years ago

Well the client, and admin area login needs to be redone as well. Testing on my own install, both can be hacked. Not sharing details since, well, that should be obvious.

mahtab2003 commented 2 years ago

Well the client, and admin area login needs to be redone as well. Testing on my own install, both can be hacked. Not sharing details since, well, that should be obvious.

Yeah that's right and also logic bombs exists in this application

0944-tw commented 2 years ago

wtf it just 1 day then lot of comment

mahtab2003 commented 2 years ago

wtf it just 1 day then lot of comment

So what?

jaikt commented 2 years ago

Can something like this being implemented correct? Reference: https://youtu.be/I4JYwRIjX6c?t=996

mahtab2003 commented 2 years ago

Can something like this being implemented correct? Reference: https://youtu.be/I4JYwRIjX6c?t=996

Yes can be.

jaikt commented 2 years ago

I am making fix for prepared stmts. https://github.com/MofhyDevs/MofhyCommunity/

greenreader9 commented 2 years ago

Um, there already is a community version...

jaikt commented 2 years ago

which no one cares to edit.

mahtab2003 commented 2 years ago

which no one cares to edit.

Well nobody cares whatever you are doing for community. They will just tell where you are wrong and will never try to fix it by there own.

ghost commented 2 years ago

which no one cares to edit.

Well nobody cares whatever you are doing for community. They will just tell where you are wrong and will never try to fix it by there own.

That's kinda sad honestly...

jaikt commented 2 years ago

That's kinda sad honestly...

agreed

greenreader9 commented 2 years ago

I mean you are not editing it either...

mahtab2003 commented 2 years ago

Who are you mentioning

jaikt commented 2 years ago

https://github.com/MyOwnFreeHostCommunity/Mofhy 🤔

greenreader9 commented 2 years ago

I am talking to @jaikt

Well the Community version here here: https://github.com/MOFH-Dev

You just made another one, when one already exists.

mahtab2003 commented 2 years ago

I am talking to @jaikt

Well the Community version here here: https://github.com/MOFH-Dev

You just made another one, when one already exists.

Well well well. That's a point

Lebyy commented 2 years ago

imo, rewriting the whole project from scratch but better this time is the best we can do rather than forking the same repo under a different organization everytime OR Create one organization where everyone who has already contributed / plans to contribute to the project with edit perms access under a private fork which will patch all security issues then release it after it's stable enough for production.

Ensuring all the security issues are patched this time.