62 filter projects on map by ccd

NYCPlanning / ae-cp-map

The front end for Application Engineering's capital projects map.

0 stars 0 forks source link

62 filter projects on map by ccd #66

Closed pratishta closed 1 month ago

pratishta commented 1 month ago

Closes https://github.com/NYCPlanning/ae-cp-map/issues/62

Waiting for the ✅ from https://github.com/NYCPlanning/ae-cp-map/pull/65 to mitigate merge conflicts. Things to note in this PR:

I pass an empty string to data instead of using the fallback geometry
I also added the hasCityCouncilDistrict boolean to both capital project and ccd layer because I wanted to more explicitly tie the highlighting of the district and the filtered project tiles together in the code

pratishta commented 1 month ago

@TangoYankee Okay thanks for flagging what the error was. There's no significant issue with fallbackGeometry but if it's possible to use an empty value for a layer data at this point in dev, I think we should. I used [] instead of "" and I didn't get that error. Is that the case for you as well? (Looking at the default value here: https://deck.gl/docs/api-reference/core/layer#data)

TangoYankee commented 1 month ago

@TangoYankee Okay thanks for flagging what the error was. There's no significant issue with fallbackGeometry but if it's possible to use an empty value for a layer data at this point in dev, I think we should. I used [] instead of "" and I didn't get that error. Is that the case for you as well? (Looking at the default value here: https://deck.gl/docs/api-reference/core/layer#data)

Thank you for pointing this out. In which case, yes it does make more sense to use an empty array than the fallback geometry. I'll update #65 to use the empty array instead of the fallback geometry