NYCPlanning / ae-cp-map

The front end for Application Engineering's capital projects map.
0 stars 0 forks source link

51/draft/capital project detail #71

Closed TangoYankee closed 1 month ago

TangoYankee commented 1 month ago

Background

@pratishta I think there is some overlap between #14 and #51. This is a ticket specifically to update the Capital Projects Detail panel to match the latest designs. However, I added some features that might come up while working on #14. I integrated as many changes from that working branch as practical to make future branch integration easier. Also, I added you as a co-author because code from your working branch is in here. I am cleaning up the code and adding some tests. But, I wanted to show the draft and start getting feedback. Some of the features are:

Features

Update Aug 16 2024

The code is updated to use the "collapse" chakra transition. It is wrapped around a filler component. This simulates how the commitments are planned to fit into the capital project panel.

The PR will remain a draft until PR #64 is on main and those changes can be integrated smoothly into these changes.

TangoYankee commented 1 month ago

Are you thinking of users who, after they choose a district to filter by, are clicking on those filtered projects on the map?

Yes, my interpretation of the designs is that the navigation icon is an indicator of which panel the user will be sent to. When it's a "close" icon, the user returns the "root" route and all of the content panels are closed. When its a "back arrow" icon, the user will return to the previous panel. This would be the content panel with the list of projects within the active district.

If the user wants to consecutively select multiple projects directly from the map and then scrub through the literal browser history of projects they looked at, then they can use the native browser history buttons.

@TylerMatteo, do you have thoughts?

TangoYankee commented 1 month ago

Closing in favor of #76