Implement findCapitalProjectsByBoroughIdCommunityDistrictId endpoint

NYCPlanning / ae-zoning-api

This application is API for serving data related to zoning and tax lots.

1 stars 0 forks source link

Implement findCapitalProjectsByBoroughIdCommunityDistrictId endpoint #247

Closed TangoYankee closed 5 days ago

TangoYankee commented 2 months ago

Acceptance criteria

[x] Implement the findCapitalProjectsByBoroughIdCommunityDistrictId endpoint in compliance with #237
- should be part of the borough domain folder
[x] Write end to end tests
[x] Write unit tests
[x] Add geospatial index

helpful code:

the tax lot domain

Related tickets

blocked by #237, #334

TangoYankee commented 1 month ago

@dhochbaum-dcp , similar to #246, the component fields of the composite key for capital projects will need to be explicitly enforced as not null. This means managing_code and id should have the notNull constraint added. This will require a migration using ~~npx drizzle-kit generate:pg and then npm run drizzle:migrate~~ ~~standby on the exact commands. It looks like we need to update drizzle-kit which will change the syntax.~~ Update: npm run drizzle:generate and npm run drizzle:migrate

TylerMatteo commented 4 weeks ago

Unfortunately didn't get too far with this but I did start a branch that someone can pick up: 247/projects-by-comm-district. It has a commit for adding the constraints @TangoYankee mentions above.

TangoYankee commented 3 weeks ago

@pratishta this ticket is affected by an incorrect geometry type. Community districts are supposed to be multipolygons. But, the 'lift' column is incorrectly typed as a 'point'. There are two fixes associated: 1) Fix the column itself 2) Remove the "patch" in the data flow

This patch was put in to coerce the geometry into a point and just get the data flow working with the database until we could correct it.

pratishta commented 3 weeks ago

Updated the draft PR with most of the work so far here: https://github.com/NYCPlanning/ae-zoning-api/pull/327#issuecomment-2177213282