NYCPlanning / ae-zoning-api

This application is API for serving data related to zoning and tax lots.

1 stars 0 forks source link

Update tests and schemas for communitydistricts by boroughID #311

Closed TangoYankee closed 4 weeks ago

TangoYankee commented 4 weeks ago

Description

Changes requested for findCommunityDistrictsByBoroughId

Acceptance criteria

Change schema/community-district to reflect updated OpenAPI pattern to include 0

[x] https://github.com/NYCPlanning/ae-zoning-api/pull/303#discussion_r1631327819

Update borough.service.e2e-spec to include a test for 404's

[x] https://github.com/NYCPlanning/ae-zoning-api/pull/303#discussion_r1631329754

Update borough.service.spec resource error with missing id test to reflect an ID not in the db instead of an empty string

[x] https://github.com/NYCPlanning/ae-zoning-api/pull/303#discussion_r1631385003