Implement find capital projects by community district endpoint - Githubissues

NYCPlanning / ae-zoning-api

This application is API for serving data related to zoning and tax lots.

1 stars 0 forks source link

Implement find capital projects by community district endpoint #327

Closed pratishta closed 14 hours ago

pratishta commented 2 weeks ago

Closes https://github.com/NYCPlanning/ae-zoning-api/issues/247

Several things to note:

Wasn't sure where to place the check for community district ID. First commit (a2a9cd8247fa2dd5b09984b56c8c7f72f8089ba6) has it in borough and second commit (bda6221615735c7fca1b31d361a4ea7713652697) has it in its own domain community-district
This endpoint is the first one where we're passing in both path and query params. I pass the ZodTransformPipe directly in the pram decorators because adding both param schemas in UsePipes() was causing errors.

pratishta commented 2 weeks ago

~~I rebased off main with the Kubb upgrade changes. There are some things I did not have time for:~~ ~~- More robust testing checking for query params e.g. default vs specified~~ - Checking for community district ID... I wasn't sure if we wanted to have that function be dependent on checking the borough ID or if they should both be independent. I chose independent in this PR and this affects the repository mock functionality as well. Addressed in description ~~- Adding the ZodTransform pipe to boroughs.controller.ts... Adding the the new pipe causes some type errors in the param I couldn't quite figure out~~ Addressed in description